Skip to content

[release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument#65331

Merged
wtgodbe merged 2 commits intorelease/8.0from
wtgodbe/GetDocument8
Feb 5, 2026
Merged

[release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument#65331
wtgodbe merged 2 commits intorelease/8.0from
wtgodbe/GetDocument8

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Feb 4, 2026

Backport of #64351, fixes a CG alert

Copilot AI review requested due to automatic review settings February 4, 2026 22:48
@wtgodbe wtgodbe changed the title Don't use netcoreapp2.1 in dotnet-getdocument [release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument Feb 4, 2026
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.x milestone Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes support for netcoreapp2.1, an unsupported framework, from the dotnet-getdocument and related tools. This is a backport to release/8.0 of PR #64351 that addresses a Component Governance alert.

Changes:

  • Removed netcoreapp2.1 from TargetFrameworks in three project files
  • Simplified version detection logic in InvokeCommand.cs to use a uniform path construction approach
  • Updated NuGet package specification to reference net8.0 instead of netcoreapp2.1

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj Removed netcoreapp2.1 from TargetFrameworks
src/Tools/dotnet-getdocument/src/Commands/InvokeCommand.cs Simplified framework version logic by removing special case for versions >= 7.0 and obsolete netcoreapp2.1 fallback
src/Tools/GetDocumentInsider/src/GetDocument.Insider.csproj Removed netcoreapp2.1 from TargetFrameworks and its specific package dependency
src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.nuspec Updated file paths from netcoreapp2.1 to net8.0
src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.csproj Removed netcoreapp2.1 from TargetFrameworks

@wtgodbe wtgodbe merged commit f48b92a into release/8.0 Feb 5, 2026
30 of 31 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/GetDocument8 branch February 5, 2026 00:40
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.25 Feb 5, 2026
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Feb 5, 2026
This was referenced Mar 10, 2026
This was referenced Mar 16, 2026
PhilipWoulfe pushed a commit to PhilipWoulfe/F1Competition that referenced this pull request Mar 16, 2026
….25 (#142)

Updated
[Microsoft.AspNetCore.Components.Authorization](https://github.com/dotnet/aspnetcore)
from 8.0.24 to 8.0.25.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.AspNetCore.Components.Authorization's
releases](https://github.com/dotnet/aspnetcore/releases)._

## 8.0.25

[Release](https://github.com/dotnet/core/releases/tag/v8.0.25)

## What's Changed
* Update branding to 8.0.25 by @​vseanreesermsft in
dotnet/aspnetcore#65293
* [release/8.0] (deps): Bump src/submodules/googletest from `9156d4c` to
`56efe39` by @​dependabot[bot] in
dotnet/aspnetcore#65289
* [release/8.0] Add support for hotfix branding by @​mmitche in
dotnet/aspnetcore#65252
* [release/8.0] Remove package baseline infrastructure by @​Copilot in
dotnet/aspnetcore#65209
* [release/8.0] Set network isolation policy for aspnetcore-ci by
@​github-actions[bot] in dotnet/aspnetcore#65173
* [release/8.0] Fix URL format for JDK download on linux by
@​github-actions[bot] in dotnet/aspnetcore#65076
* [release/8.0] Disable parallel restore for Grpc JsonTranscoding by
@​github-actions[bot] in dotnet/aspnetcore#65073
* [release/8.0] Update Ubuntu queue to 22.04 by @​github-actions[bot] in
dotnet/aspnetcore#65299
* [release/8.0] Re-enable Nuget Audit by @​wtgodbe in
dotnet/aspnetcore#65328
* [release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument by
@​wtgodbe in dotnet/aspnetcore#65331
* [release/8.0] Update AzureIdentityVersion to 1.11.4 by @​wtgodbe in
dotnet/aspnetcore#65332
* [release/8.0] Disable parallel restore for linker tests by @​wtgodbe
in dotnet/aspnetcore#65375
* Merging internal commits for release/8.0 by @​vseanreesermsft in
dotnet/aspnetcore#65382
* [release/8.0] Switch to non-preview 2022 queue by
@​github-actions[bot] in dotnet/aspnetcore#65413


**Full Changelog**:
dotnet/aspnetcore@v8.0.24...v8.0.25

Commits viewable in [compare
view](dotnet/aspnetcore@v8.0.24...v8.0.25).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.AspNetCore.Components.Authorization&package-manager=nuget&previous-version=8.0.24&new-version=8.0.25)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
PhilipWoulfe pushed a commit to PhilipWoulfe/F1Competition that referenced this pull request Mar 16, 2026
Updated
[Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore)
from 8.0.24 to 8.0.25.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.AspNetCore.Mvc.Testing's
releases](https://github.com/dotnet/aspnetcore/releases)._

## 8.0.25

[Release](https://github.com/dotnet/core/releases/tag/v8.0.25)

## What's Changed
* Update branding to 8.0.25 by @​vseanreesermsft in
dotnet/aspnetcore#65293
* [release/8.0] (deps): Bump src/submodules/googletest from `9156d4c` to
`56efe39` by @​dependabot[bot] in
dotnet/aspnetcore#65289
* [release/8.0] Add support for hotfix branding by @​mmitche in
dotnet/aspnetcore#65252
* [release/8.0] Remove package baseline infrastructure by @​Copilot in
dotnet/aspnetcore#65209
* [release/8.0] Set network isolation policy for aspnetcore-ci by
@​github-actions[bot] in dotnet/aspnetcore#65173
* [release/8.0] Fix URL format for JDK download on linux by
@​github-actions[bot] in dotnet/aspnetcore#65076
* [release/8.0] Disable parallel restore for Grpc JsonTranscoding by
@​github-actions[bot] in dotnet/aspnetcore#65073
* [release/8.0] Update Ubuntu queue to 22.04 by @​github-actions[bot] in
dotnet/aspnetcore#65299
* [release/8.0] Re-enable Nuget Audit by @​wtgodbe in
dotnet/aspnetcore#65328
* [release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument by
@​wtgodbe in dotnet/aspnetcore#65331
* [release/8.0] Update AzureIdentityVersion to 1.11.4 by @​wtgodbe in
dotnet/aspnetcore#65332
* [release/8.0] Disable parallel restore for linker tests by @​wtgodbe
in dotnet/aspnetcore#65375
* Merging internal commits for release/8.0 by @​vseanreesermsft in
dotnet/aspnetcore#65382
* [release/8.0] Switch to non-preview 2022 queue by
@​github-actions[bot] in dotnet/aspnetcore#65413


**Full Changelog**:
dotnet/aspnetcore@v8.0.24...v8.0.25

Commits viewable in [compare
view](dotnet/aspnetcore@v8.0.24...v8.0.25).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.AspNetCore.Mvc.Testing&package-manager=nuget&previous-version=8.0.24&new-version=8.0.25)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
PhilipWoulfe pushed a commit to PhilipWoulfe/F1Competition that referenced this pull request Mar 16, 2026
Updated
[Microsoft.AspNetCore.OpenApi](https://github.com/dotnet/aspnetcore)
from 8.0.24 to 8.0.25.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.AspNetCore.OpenApi's
releases](https://github.com/dotnet/aspnetcore/releases)._

## 8.0.25

[Release](https://github.com/dotnet/core/releases/tag/v8.0.25)

## What's Changed
* Update branding to 8.0.25 by @​vseanreesermsft in
dotnet/aspnetcore#65293
* [release/8.0] (deps): Bump src/submodules/googletest from `9156d4c` to
`56efe39` by @​dependabot[bot] in
dotnet/aspnetcore#65289
* [release/8.0] Add support for hotfix branding by @​mmitche in
dotnet/aspnetcore#65252
* [release/8.0] Remove package baseline infrastructure by @​Copilot in
dotnet/aspnetcore#65209
* [release/8.0] Set network isolation policy for aspnetcore-ci by
@​github-actions[bot] in dotnet/aspnetcore#65173
* [release/8.0] Fix URL format for JDK download on linux by
@​github-actions[bot] in dotnet/aspnetcore#65076
* [release/8.0] Disable parallel restore for Grpc JsonTranscoding by
@​github-actions[bot] in dotnet/aspnetcore#65073
* [release/8.0] Update Ubuntu queue to 22.04 by @​github-actions[bot] in
dotnet/aspnetcore#65299
* [release/8.0] Re-enable Nuget Audit by @​wtgodbe in
dotnet/aspnetcore#65328
* [release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument by
@​wtgodbe in dotnet/aspnetcore#65331
* [release/8.0] Update AzureIdentityVersion to 1.11.4 by @​wtgodbe in
dotnet/aspnetcore#65332
* [release/8.0] Disable parallel restore for linker tests by @​wtgodbe
in dotnet/aspnetcore#65375
* Merging internal commits for release/8.0 by @​vseanreesermsft in
dotnet/aspnetcore#65382
* [release/8.0] Switch to non-preview 2022 queue by
@​github-actions[bot] in dotnet/aspnetcore#65413


**Full Changelog**:
dotnet/aspnetcore@v8.0.24...v8.0.25

Commits viewable in [compare
view](dotnet/aspnetcore@v8.0.24...v8.0.25).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.AspNetCore.OpenApi&package-manager=nuget&previous-version=8.0.24&new-version=8.0.25)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
PhilipWoulfe pushed a commit to PhilipWoulfe/F1Competition that referenced this pull request Mar 16, 2026
#143)

Updated
[Microsoft.AspNetCore.Components.WebAssembly](https://github.com/dotnet/aspnetcore)
from 8.0.24 to 8.0.25.

<details>
<summary>Release notes</summary>

_Sourced from [Microsoft.AspNetCore.Components.WebAssembly's
releases](https://github.com/dotnet/aspnetcore/releases)._

## 8.0.25

[Release](https://github.com/dotnet/core/releases/tag/v8.0.25)

## What's Changed
* Update branding to 8.0.25 by @​vseanreesermsft in
dotnet/aspnetcore#65293
* [release/8.0] (deps): Bump src/submodules/googletest from `9156d4c` to
`56efe39` by @​dependabot[bot] in
dotnet/aspnetcore#65289
* [release/8.0] Add support for hotfix branding by @​mmitche in
dotnet/aspnetcore#65252
* [release/8.0] Remove package baseline infrastructure by @​Copilot in
dotnet/aspnetcore#65209
* [release/8.0] Set network isolation policy for aspnetcore-ci by
@​github-actions[bot] in dotnet/aspnetcore#65173
* [release/8.0] Fix URL format for JDK download on linux by
@​github-actions[bot] in dotnet/aspnetcore#65076
* [release/8.0] Disable parallel restore for Grpc JsonTranscoding by
@​github-actions[bot] in dotnet/aspnetcore#65073
* [release/8.0] Update Ubuntu queue to 22.04 by @​github-actions[bot] in
dotnet/aspnetcore#65299
* [release/8.0] Re-enable Nuget Audit by @​wtgodbe in
dotnet/aspnetcore#65328
* [release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument by
@​wtgodbe in dotnet/aspnetcore#65331
* [release/8.0] Update AzureIdentityVersion to 1.11.4 by @​wtgodbe in
dotnet/aspnetcore#65332
* [release/8.0] Disable parallel restore for linker tests by @​wtgodbe
in dotnet/aspnetcore#65375
* Merging internal commits for release/8.0 by @​vseanreesermsft in
dotnet/aspnetcore#65382
* [release/8.0] Switch to non-preview 2022 queue by
@​github-actions[bot] in dotnet/aspnetcore#65413


**Full Changelog**:
dotnet/aspnetcore@v8.0.24...v8.0.25

Commits viewable in [compare
view](dotnet/aspnetcore@v8.0.24...v8.0.25).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Microsoft.AspNetCore.Components.WebAssembly&package-manager=nuget&previous-version=8.0.24&new-version=8.0.25)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants